Changeset 991 for trunk/bureau/class/m_quota.php

Timestamp:

04/05/06 21:20:50 (7 years ago)

Author:

joe

Message:

Amélioration du 'workflow' des quotas. Ajout de vérifications additionelles pour les quotas. Optimisation et évitement de 'race-conditions' dans les requètes MySQL de quotas. C'est tout :-).

File:

• trunk/bureau/class/m_quota.php (modified) (3 diffs)

trunk/bureau/class/m_quota.php

@@ -253 +253 @@
 
     foreach($newq as $type => $quotas) {
-      reset($qlist);
-      foreach($qlist as $qname => $val) {
-        if($quota==$qname){
-          $db->query("SELECT value FROM defquotas WHERE type='$type' AND quota='$qname'");
-          if (!$db->next_record()) {
-            $db->query("INSERT INTO defquotas (value,quota,type) VALUES ('".$quotas[$qname]."','$key','$type');");
-          } else {
-            $db->query("UPDATE defquotas SET value='".$quotas[$qname]."' WHERE type='$type' AND quota='$qname';");
-          }
-        }
+      foreach($quotas as $qname => $value) {
+        if(array_key_exists($qname, $qlist)) {
+          if(!$db->query("REPLACE INTO defquotas (value,quota,type) VALUES ($value,'$qname','$type');"))
+            return false;
+        }
       }
     }
@@ -278 +273 @@
     reset($qlist);
     while (list($key,$val)=each($qlist)) {
-      $db->query("SELECT value FROM defquotas WHERE quota='$key' AND type='$type'");
-      if (!$db->next_record()) {
-        $db->query("INSERT INTO defquotas (quota,type) VALUES('$key', '$type');");
-      }
-    }
+      if(!$db->query("REPLACE INTO defquotas (quota,type) VALUES('$key', '$type');"))
+        return false;
+    }
+    return true;
   }
 
@@ -295 +289 @@
     reset($qlist);
 
-    $db->query("UPDATE membres SET type='default' WHERE type='$type'");
-    $db->query("DELETE FROM defquotas WHERE type='$type'");
+    if($db->query("UPDATE membres SET type='default' WHERE type='$type'") &&
+       $db->query("DELETE FROM defquotas WHERE type='$type'")) {
+      return true;
+    } else {
+      return false;
+    }
   }