Changeset 2478

Timestamp:

02/27/09 01:31:59 (4 years ago)

Author:

anarcat

Message:

small API change: do not include the db size in get_db_list(), which improves performance on big databases

Location:

alternc/trunk

Files:

• bureau/admin/sql_list.php (modified) (1 diff)
• bureau/class/m_mysql.php (modified) (2 diffs)
• debian/changelog (modified) (1 diff)

alternc/trunk/bureau/admin/sql_list.php

@@ -57 +57 @@
 for($i=0;$i<count($r);$i++) {
   $val=$r[$i];
+  $val['size'] = $mysql->get_db_size($val['db']);
  $col=3-$col;
 ?>

alternc/trunk/bureau/class/m_mysql.php

@@ -61 +61 @@
    *  "db" => database name "bck" => backup mode for this db 
    *  "dir" => Backup folder.
-   *  "size" => Size of the database (in bytes)
    *  Returns FALSE if the user has no database.
    */
@@ -76 +75 @@
       list($dbu,$dbn)=split_mysql_database_name($db->f("db"));
       $c[]=array("db"=>$db->f("db"), "name"=>$dbn,"bck"=>$db->f("bck_mode"), "dir"=>$db->f("bck_dir"), "login"=>$db->f("login"), "pass"=>$db->f("pass"));
-    }
-    
-    /* find the size of each database */
-    foreach ($c as $key => $val) {
-      $c[$key]['size'] = $this->get_db_size($c[$key]['db']);
     }
     return $c;

alternc/trunk/debian/changelog

@@ -17 +17 @@
     * send an email on new account creation. the actual email needs to be
       configured through the AlternC variables for this to work.
+  * API changes
+    * m_mysql->get_db_list() doesn't include size anymore because this
+      is a major performance hit on MySQL < 5.1.22 if there are > 1000
+      databases on the system. This speeds up the AlternC login by about
+      30 seconds on Koumbit.org.
 
  -- Antoine Beaupré <anarcat@koumbit.org>  Wed, 28 Jan 2009 19:52:46 -0500