Changeset 1772

Timestamp:

01/13/07 00:03:33 (2 years ago)

Author:

anarcat

Message:

Fix a race condition in update_domaines.sh that could allow users to
bypass open_basedir protections when creating domains. Reported by
jerome.

This required changing basedir_prot's behavior so that it creates the
protection even if the symlink doesn't exist, which might create extra
files that are not necessary, but "better be safe than sorry". We
could also fix this in a subsequent release.

Files:

• alternc/trunk/debian/changelog (modified) (1 diff)
• alternc/trunk/src/basedir_prot.sh (modified) (1 diff)
• alternc/trunk/src/update_domains.sh (modified) (6 diffs)

alternc/trunk/debian/changelog

@@ -6 +6 @@
-  * Make it possible to erase files and directories in file browser. Closes: #1002.
-  * Fix mail accounts creation. Closes: #1003.
+  * Fix a race condition in update_domains.sh which could allow users to
+    bypass openbasedir protection when creating domains. Reported by 
+    Jerome Moinet.
-
- -- Antoine Beaupré <anarcat@koumbit.org>  Fri, 12 Jan 2007 15:59:42 -0500

alternc/trunk/src/basedir_prot.sh

@@ -94 +94 @@
-                    dom="/var/alternc/dns/$initial_domain/$i"
-                fi
-
-
-
-
-
+
-        done
-else

alternc/trunk/src/update_domains.sh

@@ -124 +124 @@
-add_to_php_override() {
-    local fqdn="$1"
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
-}
-
@@ -236 +241 @@
-    delete_host "$domain" "$host"
-
+    if [ "$host" = "@" -o -z "$host" ]; then
+        FQDN="$domain"
+    else
+        FQDN="$host.$domain"
+    fi
+    if [ "$host_type" != "$TYPE_IP" ]; then
+        add_to_php_override "$FQDN"
+    fi
+
-    if [ "$host_type" = "$TYPE_IP" ]; then
-       ip="$value"
@@ -395 +409 @@
-HOSTS_TMP_FILE=`mktemp -t alternc.update_domains.XXXXXX`
-RELOAD_ZONES_TMP_FILE=`mktemp -t alternc.update_domains.XXXXXX`
-CHANGED_PHP_OVERRIDES_TMP_FILE=`mktemp -t alternc.update_domains.XXXXXX`
-
-cleanup() {
-    rm -f "$LOCK_FILE" "$DOMAINS_TMP_FILE" "$HOSTS_TMP_FILE"
- "$CHANGED_PHP_OVERRIDES_TMP_FILE"
+
-    exit 0
-}
@@ -450 +463 @@
-    USER_LETTER=`print_user_letter "$user"`
-
-    add_to_php_override "$domain"
-    add_to_php_override "www.$domain"
-
-    case "$action" in
-      $ACTION_INSERT)
@@ -500 +510 @@
-    IFS="$OLD_IFS"
-
-    if [ "$host" = "@" -o -z "$host" ]; then
-        FQDN="$domain"
-    else
-        FQDN="$host.$domain"
-    fi
-    if [ "$type" != "$TYPE_IP" ]; then
-        add_to_php_override "$FQDN"
-    fi
-
-    case "$action" in
-      $ACTION_UPDATE | $ACTION_INSERT)
@@ -526 +527 @@
-done < "$HOSTS_TMP_FILE"
-IFS="$OLD_IFS"
-
-# Update PHP overrides (basedir protection)
-for domain in `cat "$CHANGED_PHP_OVERRIDES_TMP_FILE"`; do
-    /usr/lib/alternc/basedir_prot.sh "$domain" >> "$DOMAIN_LOG_FILE"
-done
-
-# Reload configuration for named and apache